Feat/registries auth implementation by Leay15 · Pull Request #370 · superradcompany/microsandbox

Leay15 · 2026-02-10T01:53:55Z

This pull request refers to #364 introduces robust support for registry authentication in the microsandbox CLI and core library, allowing users to securely pull and push images from private registries.

It adds new CLI commands for login/logout, implements environment and stored credential resolution, and integrates these mechanisms into image operations.

Documentation is updated to reflect these new features and usage patterns.

All test are passing OK

Registry Authentication Features

Added new CLI commands: msb login and msb logout for managing registry credentials, including support for username/password and token-based authentication, with credentials stored locally in ~/.microsandbox/registry_auth.json. [1] [2]
Implemented environment variable support for registry credentials (MSB_REGISTRY_USERNAME, MSB_REGISTRY_PASSWORD, MSB_REGISTRY_TOKEN), with clear priority: environment variables override stored credentials, and both are used for authentication when pulling/pushing images. [1] [2]

Core Library Enhancements

Introduced resolve_registry_auth and related utilities in microsandbox-core/lib/oci/auth.rs, providing normalization, host resolution, and credential lookup logic, including comprehensive tests for all resolution scenarios.
Integrated registry authentication into image pulling logic, passing resolved credentials to the registry client and updating relevant constructors and mocks. [1] [2] [3] [4] [5]

Documentation and Testing

Updated CLI documentation with examples and security notes for authentication workflows, including environment variable usage and credential storage warnings. [1] [2]
Added integration and unit tests for registry auth resolution, covering environment, stored, and fallback scenarios. [1] [2]

Utilities and Re-exports

Added new environment variable constants and dependencies to support credential management and serialization. [1] [2]
Re-exported registry auth resolution utilities for compatibility and easier access in management modules. [1] [2] [3] [4]

These changes collectively provide a secure, flexible, and user-friendly registry authentication system for microsandbox users.

…try credentials

…ntication

…ntials handling

…hentication

…d credential management

…uration

…registry authentication commands

…ring and managing credentials

…environment variable overrides

…utilities

…te non-validation

…n registry credentials loading

…figuration and handler files

…b login

…uthentication files

…stry authentication files

….toml

…ation functions

…resolution

…dling

…dence

Leay15 · 2026-02-14T05:28:48Z

@toksdotdev All the modifications were addressed according to your feedback.

I'll be waiting for any further comments.

toksdotdev

i'm sorry, but i have quite a number of reservations with this MR. it seems to me most of these were generated by AI, and hardly underwent much human review. while i'm not against AI generated code (i use it as well, i'm against humans not spending enough time reviewing their code). the implication of that is, most of the responsibilities are shifted to the reviewer which i don't think is great.

i definitely appreciate the contribution, but please spend time reviewing your changes before putting it up for review. i'm also up for discussing approaches in the github thread before implementation. that way, we can avoid multiple back-and-forths.

microsandbox-utils/lib/env.rs

microsandbox-core/lib/oci/reference.rs

microsandbox-utils/lib/credential_store.rs

toksdotdev · 2026-02-15T08:45:26Z

microsandbox-utils/lib/docker_config.rs

could you create this as a separate PR after this is merged. makes it easier to review and test.

microsandbox-utils/lib/credential_store.rs

microsandbox-core/lib/oci/registry.rs

microsandbox-utils/lib/credential_store.rs

Leay15 · 2026-02-15T19:05:16Z

@toksdotdev, thank you so much for your feedback. I'll be working on it.

Please excuse the AI code, which appears unreviewed. I'm still learning from the code I review and the feedback I've received. I can assure you that I don't upload code that I haven't reviewed, tested, and that doesn't make sense to me. Therefore, I greatly appreciate your comments and support in continuing to improve.

…better understanding

…nd consistency

…eadability

… load_registry_credentials for clarity

…other PR

…istryAuth for consistency

…to RegistryAuth

…istry credentials

…simplify logout command

…s to use RegistryAuth

…ion' into feat/registries-auth-implementation

…bility

…lity

Leay15 · 2026-02-15T23:10:13Z

@toksdotdev all modifications done 😄

In the registry.rs file, I couldn't decouple the resolve_auth function in the tests because OciClient was causing a panic. I ran out of ideas and for now, I've implemented a wrapper function to test the behavior.

I'm open to suggestions if there's a better way I'm missing and welcome any comments.

Thank you again for all your patience and the kind comments you give me

…improve security notes

Leay15 · 2026-02-15T23:45:38Z

While testing directly with the keychain, I've encountered a bug that I'll be working on. Nothing from the login is being saved. I've already tested the pull method using ENV vars, and that works correctly.

Leay15 · 2026-02-16T00:03:14Z

The bug was fixed 😄 , just I need to know if we have to add windows support for keyring or just Linux and MacOs

toksdotdev · 2026-04-01T23:06:09Z

hey @Leay15. apologies i didn't get back on this. a lot of things have changed, and there's now auth support in the latest version. i'll proceed to close this now, but please do feel free to let me know if you've got other ideas in mind.

Leay15 added 28 commits February 9, 2026 19:51

feat(env): add environment variables for Docker registry configuration

6dd3ad9

feat(error): add Serde JSON error variant to error handling

ba7b45e

feat(auth): implement login and logout functionality for Docker regis…

c0423de

…try credentials

feat(docker): add modules for Docker configuration and registry authe…

4d46b9f

…ntication

feat(auth): enhance login and logout commands with registry and crede…

0ba304d

…ntials handling

feat(docker): update registry initialization to support anonymous aut…

682529e

…hentication

feat(auth): extend login and logout commands with registry options an…

f9420df

…d credential management

feat(docker): integrate registry authentication into OciClient config…

01c1ddf

…uration

feat(docker): update CLI documentation for private image pulling and …

9d40c6b

…registry authentication commands

feat(docker): implement Docker config reader for registry authentication

ce08cbf

feat(docker): add registry authentication persistence helpers for sto…

f3fad36

…ring and managing credentials

feat(docker): add integration tests for registry authentication with …

6abaccd

…environment variable overrides

feat(docker): add usage examples for Docker config and registry auth …

a2cab94

…utilities

feat(docker): update logging for saved registry credentials to indica…

f2735b5

…te non-validation

feat(docker): remove TODO for supporting credsStore and credHelpers i…

bc16252

…n registry credentials loading

feat(docker): clean up code formatting and improve readability in con…

42d3c47

…figuration and handler files

feat(docker): add note about credential storage and validation for ms…

b406bfb

…b login

feat(docker): reorder imports for improved organization in registry a…

2c72e6c

…uthentication files

feat(docker): reorganize imports for better clarity in image and regi…

baf1124

…stry authentication files

feat(docker): add base64, serde, and serde_json dependencies to Cargo…

2bd30ba

….toml

feat(auth): implement registry authentication resolution and normaliz…

8e20a7c

…ation functions

feat(auth): add compatibility re-exports for registry authentication …

7efb79d

…resolution

feat(auth): normalize registry host in resolve_registry_host function

a343da7

feat(auth): integrate registry authentication resolution in image han…

d4e4faf

…dling

feat(image): add image module to the project

158487a

feat(auth): expose registry authentication functions in the module

47c1505

feat(cli): clarify credential handling and environment variable prece…

c1ba28f

…dence

fix(auth): clean up import formatting in auth and mod files

88e3112

Leay15 requested review from appcypher and toksdotdev as code owners February 10, 2026 01:53

toksdotdev requested changes Feb 15, 2026

View reviewed changes

toksdotdev reviewed Feb 15, 2026

View reviewed changes

microsandbox-utils/lib/credential_store.rs Outdated Show resolved Hide resolved

Leay15 and others added 18 commits February 15, 2026 13:49

enhance(env): uses MSB_REGISTRY_HOST_ENV_VAR in get_oci_registry for …

1042575

…better understanding

enhance(oci): uses oci_registry and normalizes its content

d803ee8

enhance(reference): refactor registry resolution to improve clarity a…

06696c3

…nd consistency

enhance(reference): simplify registry resolution logic for improved r…

dc2bd1f

…eadability

enhance(credential_store): rename load_stored_registry_credentials to…

4346167

… load_registry_credentials for clarity

chore(docker_config): removes docker_config.rs for being review in an…

a8f54d7

…other PR

chore(lib): remove docker_config module for future review

0ac59eb

chore(credential_store): changes keyring reference for using host key

499b715

enhance(credential_store): rename StoredRegistryCredentials to MsbReg…

c35e00c

…istryAuth for consistency

enhance(credential_store): implement conversion from MsbRegistryAuth …

a246458

…to RegistryAuth

Merge branch 'main' into feat/registries-auth-implementation

26ff560

fix(handlers): simplify logout_subcommand to remove only resolved reg…

1f54993

…istry credentials

enhance(registry): refactor auth handling to use CredentialStore and …

cc47a84

…simplify logout command

enhance(tests): update fetch_index and fetch_manifest_and_config test…

c4ce894

…s to use RegistryAuth

Merge remote-tracking branch 'origin/feat/registries-auth-implementat…

8270100

…ion' into feat/registries-auth-implementation

enhance(credential_store): simplify code formatting and improve reada…

c4c22de

…bility

enhance(handlers): reorder imports and simplify string normalization

6b87b28

enhance(registry): simplify auth resolution logic and improve readabi…

ccee9ca

…lity

enhance(cli): update login instructions for registry credentials and …

9d52751

…improve security notes

Leay15 added 2 commits February 15, 2026 17:48

chore(cargo): remove unused url workspace entry

24e1a31

fix(keyring): add platform-specific dependencies for macOS and Linux

6f3211a

toksdotdev closed this Apr 1, 2026

Conversation

Leay15 commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Registry Authentication Features

Core Library Enhancements

Documentation and Testing

Utilities and Re-exports

Uh oh!

Leay15 commented Feb 14, 2026

Uh oh!

toksdotdev left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

toksdotdev Feb 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Leay15 commented Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Leay15 commented Feb 15, 2026

Uh oh!

Leay15 commented Feb 15, 2026

Uh oh!

Leay15 commented Feb 16, 2026

Uh oh!

toksdotdev commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Leay15 commented Feb 10, 2026 •

edited

Loading

toksdotdev left a comment •

edited

Loading

Leay15 commented Feb 15, 2026 •

edited

Loading